feat: explicit soft logout#43
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 78.66% 78.57% -0.09%
==========================================
Files 472 472
Lines 67661 67569 -92
Branches 10419 10419
==========================================
- Hits 53225 53094 -131
- Misses 10920 10936 +16
- Partials 3516 3539 +23
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jason-famedly
left a comment
jason-famedly
left a comment
There was a problem hiding this comment.
Other than the few comment typos, I'm largely good with this.
We probably do not use the /logout endpoint on workers, although it should be workable but not documented, and it appears this does not touch anything that would break that. 🚀 Let's do it!
nico-famedly
force-pushed
the
nico/explicit-soft-logout
branch
from
1ea25be to
4bf5893
Compare
Allows invalidating all access tokens and refresh tokens for a specific session by setting "com.famedly.soft_logout" to "true" on the logout endpoint. This only updates the expiry timestamps to be in the past. Otherwise the tokens will get deleted, which forces a real logout. Fixes famedly/product-management#3202
nico-famedly
force-pushed
the
nico/explicit-soft-logout
branch
from
4bf5893 to
17b819f
Compare
2 participants
Allows invalidating all access tokens and refresh tokens for a specific session by setting "com.famedly.soft_logout" to "true" on the logout endpoint.
This only updates the expiry timestamps to be in the past. Otherwise the tokens will get deleted, which forces a real logout.
Fixes https://github.com/famedly/product-management/issues/3202